Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to download all the files in an artifact using oras.Copy() #256

Merged
merged 7 commits into from
Aug 4, 2022

Conversation

m5i-work
Copy link
Contributor

@m5i-work m5i-work commented Jul 28, 2022

Resolves #236

Signed-off-by: Wei Meng [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #256 (680ecd3) into main (6a09a65) will decrease coverage by 0.08%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
- Coverage   70.57%   70.48%   -0.09%     
==========================================
  Files          35       35              
  Lines        3055     3087      +32     
==========================================
+ Hits         2156     2176      +20     
- Misses        669      678       +9     
- Partials      230      233       +3     
Impacted Files Coverage Δ
content/file/file.go 75.57% <62.50%> (-1.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@m5i-work
Copy link
Contributor Author

@qweeah @Wwwsylvia @shizhMSFT Please take a look when you have time.

@Wwwsylvia
Copy link
Member

Wwwsylvia commented Jul 28, 2022

I think you wanted to reference issue #236?

copy_test.go Show resolved Hide resolved
Signed-off-by: Wei Meng <[email protected]>
Signed-off-by: Wei Meng <[email protected]>
Signed-off-by: Wei Meng <[email protected]>
Signed-off-by: Wei Meng <[email protected]>
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

content/file/file.go Outdated Show resolved Hide resolved
content/file/file.go Outdated Show resolved Hide resolved
Signed-off-by: Wei Meng <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 5115985 into oras-project:main Aug 4, 2022
@m5i-work m5i-work deleted the dup branch August 4, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to download all the files in an artifact using oras.Copy()
5 participants