Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping unnamed blobs when pushing to file store #254

Merged
merged 7 commits into from
Aug 4, 2022

Conversation

m5i-work
Copy link
Contributor

Resolves #213

Signed-off-by: Wei Meng [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #254 (2d8be60) into main (fda65b9) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   70.48%   70.52%   +0.03%     
==========================================
  Files          35       35              
  Lines        3087     3091       +4     
==========================================
+ Hits         2176     2180       +4     
  Misses        678      678              
  Partials      233      233              
Impacted Files Coverage Δ
content/file/file.go 75.82% <100.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@m5i-work
Copy link
Contributor Author

@shizhMSFT @Wwwsylvia Please take a look when you have time.

content/file/file.go Outdated Show resolved Hide resolved
content/file/file_test.go Outdated Show resolved Hide resolved
content/file/file_test.go Show resolved Hide resolved
Signed-off-by: Wei Meng <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question on how manifest is processed since we need the manifest while the manifests usually does not have a name.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

content/file/errors.go Outdated Show resolved Hide resolved
Signed-off-by: Wei Meng <[email protected]>
Signed-off-by: Wei Meng <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit e135557 into oras-project:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow skipping unnamed blobs when pushing to file store
4 participants