moved ReadAll and related functions to package Content #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wwwsylvia
requested changes
Jul 20, 2022
qweeah
reviewed
Jul 21, 2022
|
Can we also update the examples using |
|
I'll open another pr to replace io.ReadAll. |
Wwwsylvia
requested changes
Jul 21, 2022
Wwwsylvia
reviewed
Jul 22, 2022
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
binbin-li
reviewed
Jul 22, 2022
| verifier := desc.Digest.Verifier() | ||
| r = io.TeeReader(r, verifier) | ||
| _, err := io.ReadFull(r, buf) | ||
| // verify the size of the read content |
There was a problem hiding this comment.
Does the comment relate to the next line code?
There was a problem hiding this comment.
Yes. The check is done by checking the err value returned by ReadAll() and EnsureEOF().
There was a problem hiding this comment.
Deleted this line of comment to avoid confusions.
There was a problem hiding this comment.
i see, I feel it might be better to move it above _, err := io.ReadFull(r, buf) and we can put it with err check together in the if statement.
There was a problem hiding this comment.
Changed accordingly.
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
This was referenced Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wangxiaoxuan273 [email protected]
Resolves #128