Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created pull blob example #234

Merged
merged 4 commits into from
Jul 21, 2022
Merged

created pull blob example #234

merged 4 commits into from
Jul 21, 2022

Conversation

wangxiaoxuan273
Copy link
Contributor

Signed-off-by: wangxiaoxuan273 [email protected]

Part of issue #178

Added an example of pulling the blobs of an ORAS artifact manifest.

registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Outdated Show resolved Hide resolved
@Wwwsylvia
Copy link
Member

@qweeah Would you like to take a look?

registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Show resolved Hide resolved
registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Show resolved Hide resolved
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We still need an issue to update the digest validation after blob fetching with promoted .FetchAll

Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
@Wwwsylvia Wwwsylvia merged commit 2054bc5 into oras-project:main Jul 21, 2022
@wangxiaoxuan273 wangxiaoxuan273 deleted the dl-blobs branch July 21, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants