Skip to content
This repository has been archived by the owner on Apr 7, 2024. It is now read-only.

feat: Support creating store from a config file #47

Merged
merged 34 commits into from
Apr 21, 2023
Merged

feat: Support creating store from a config file #47

merged 34 commits into from
Apr 21, 2023

Conversation

Wwwsylvia
Copy link
Member

Resolves: #30

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023 •
edited
Loading

Codecov Report

Merging #47 (933f90d) into main (8f27cf8) will decrease coverage by 19.45%.
The diff coverage is 48.29%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main      #47       +/-   ##
===========================================
- Coverage   77.91%   58.47%   -19.45%     
===========================================
  Files           4        6        +2     
  Lines         240      354      +114     
===========================================
+ Hits          187      207       +20     
- Misses         39      125       +86     
- Partials       14       22        +8
Impacted Files Coverage Δ
internal/config/config.go 32.51% <32.51%> (ø)
native_store.go 76.92% <50.00%> (+7.22%) ⬆️
native_store_linux.go 80.00% <80.00%> (ø)
store.go 80.00% <84.09%> (+8.57%) ⬆️
file_store.go 100.00% <100.00%> (+17.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

qweeah
qweeah reviewed Apr 20, 2023
View reviewed changes
internal/config/config.go Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT reviewed Apr 20, 2023
View reviewed changes
dynamic_store.go Outdated Show resolved Hide resolved
default_native_helper_darwin.go Outdated Show resolved Hide resolved
default_native_helper_unsupported.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT reviewed Apr 20, 2023
View reviewed changes
internal/config/config.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT reviewed Apr 20, 2023
View reviewed changes
internal/config/config.go Show resolved Hide resolved
file_store.go Outdated Show resolved Hide resolved
Wwwsylvia and others added 22 commits April 20, 2023 19:07
@Wwwsylvia
draft dynamic store
fe06818 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
add docs
8b441cc 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
add tests
db2481b 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
improve docs
a9f71db 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
rebase
1e51c1a 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
refactor config
fdd8bf4 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
refactor more
edbb72b 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
refactor dynamic store
16b2c25 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
rename fileds
3f4a9f2 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
marshal cred store
0df1d76 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
refactor internal
f119c09 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
add tests
be7367a 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
support default helper
928c0e0 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
config doc
6422339 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
refactor dynamic store
895d28d 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
fix
7a7e7b3 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
rename internal
2e1c6b3 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
fix
ee0f73c 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
fix license + reference
263529c 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
rename + remove unnecessary code
9e693d5 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
reformat
d44d906 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
address comments
129aef2 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
address comments
7851287 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
rebase
dae7c9a 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
moved to store.go
ec7bfc9 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
minor improvement
f47742d 
Signed-off-by: Sylvia Lei <[email protected]>
patrickzheng200
patrickzheng200 reviewed Apr 21, 2023
View reviewed changes
store.go Outdated Show resolved Hide resolved
store.go Show resolved Hide resolved
store.go Outdated Show resolved Hide resolved
internal/config/config.go Show resolved Hide resolved
internal/config/config.go Show resolved Hide resolved
@Wwwsylvia
refactor dynamic store
c7b4d51 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
update doc
28b49a2 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
minor change
38586e0 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
improve tests
14da58b 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
minor fix name
aaf7548 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
check colons in username
9a9b85b 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
improve test
daf6521 
Signed-off-by: Sylvia Lei <[email protected]>
shizhMSFT
shizhMSFT reviewed Apr 21, 2023
View reviewed changes
internal/config/config.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
store.go Outdated Show resolved Hide resolved
@Wwwsylvia
address comments
933f90d 
Signed-off-by: Sylvia Lei <[email protected]>
shizhMSFT
shizhMSFT approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 5458be0 into oras-project:main Apr 21, 2023
@Wwwsylvia Wwwsylvia deleted the newstore branch April 21, 2023 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@patrickzheng200 patrickzheng200 patrickzheng200 left review comments

@qweeah qweeah qweeah left review comments

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support creating store from a config file
5 participants
@Wwwsylvia @codecov-commenter @qweeah @shizhMSFT @patrickzheng200