Skip to content
This repository has been archived by the owner on Apr 7, 2024. It is now read-only.

feat: Implement File Store #43

Merged
merged 47 commits into from
Apr 14, 2023
Merged

feat: Implement File Store #43

merged 47 commits into from
Apr 14, 2023

Conversation

Wwwsylvia
Copy link
Member

Resolves: #28

Wwwsylvia added 20 commits April 6, 2023 20:08
@Wwwsylvia
file store
501cd29 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
draft get
e02b9c8 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
fix test
8a059dc 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
improvement
b028482 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
draft put
e61d317 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
refactor put
c132d37 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
draft delete
1fa25cf 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
fix
9ec9a1a 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
test get
6711216 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
clean up
f25afb8 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
test put
23f4f98 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
remove not found error
3123148 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
draft encode/decode
2cb14e4 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
test decode
7a010c0 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
fix get username password
5662d0c 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
improvement and TODOs
6399b9f 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
more test cases
1f619a9 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
improve unit tests
0bb94eb 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
fix savefile
93f93f5 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
document variables
10ef4a9 
Signed-off-by: Sylvia Lei <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023 •
edited
Loading

Codecov Report

Merging #43 (f3eaeb0) into main (aead42c) will increase coverage by 8.62%.
The diff coverage is 82.57%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   69.69%   78.32%   +8.62%     
==========================================
  Files           1        3       +2     
  Lines          33      203     +170     
==========================================
+ Hits           23      159     +136     
- Misses          9       33      +24     
- Partials        1       11      +10
Impacted Files Coverage Δ
file_store.go 82.57% <82.57%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

qweeah
qweeah suggested changes Apr 7, 2023
View reviewed changes
file_store.go Outdated Show resolved Hide resolved
internal/ioutils/ioutils.go Outdated Show resolved Hide resolved
file_store_test.go Outdated Show resolved Hide resolved
binbin-li
binbin-li reviewed Apr 7, 2023
View reviewed changes
internal/ioutils/ioutils.go Outdated Show resolved Hide resolved
file_store.go Outdated Show resolved Hide resolved
Wwwsylvia added 5 commits April 7, 2023 18:49
@Wwwsylvia
rename temp file
e14d1c4 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
minor fix test data
5d1ab3e 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
fix new
3afa112 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
minor improve coverage
81cd939 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
omit empty
3a35144 
Signed-off-by: Sylvia Lei <[email protected]>
Wwwsylvia added 2 commits April 7, 2023 21:14
@Wwwsylvia
change test auth config type
34882d3 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
empty line
e66df92 
Signed-off-by: Sylvia Lei <[email protected]>
shizhMSFT
shizhMSFT reviewed Apr 10, 2023
View reviewed changes
file_store.go Outdated Show resolved Hide resolved
Wwwsylvia added 11 commits April 10, 2023 22:35
@Wwwsylvia
rename
c1ab88e 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
ingest
724e510 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
add reference comment
b021344 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
use json.RawMessage
be237e3 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
refactor
5500dad 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
extract
8541222 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
optimize decoding
ebe4f8b 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
remove unnecessary functions
2ceda3e 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
add auths cache
ae78e11 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
refactor
dbb8dd2 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
clean up
e951fb5 
Signed-off-by: Sylvia Lei <[email protected]>
shizhMSFT
shizhMSFT reviewed Apr 11, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better if we can write modern go code.

internal/ioutil/ioutil.go Outdated Show resolved Hide resolved
internal/ioutil/ioutil_unix.go Outdated Show resolved Hide resolved
file_store.go Outdated Show resolved Hide resolved
file_store.go Outdated Show resolved Hide resolved
file_store.go Outdated Show resolved Hide resolved
file_store.go Outdated Show resolved Hide resolved
file_store.go Outdated Show resolved Hide resolved
file_store.go Outdated Show resolved Hide resolved
file_store.go Outdated Show resolved Hide resolved
file_store.go Outdated Show resolved Hide resolved
@Wwwsylvia
refactors per comments
4952d07 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
improvements per comments
0bd4c81 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
more improvements
28a0d26 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
rename testdata
76fa5ed 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
improve testdata
1db937c 
Signed-off-by: Sylvia Lei <[email protected]>
shizhMSFT
shizhMSFT reviewed Apr 13, 2023
View reviewed changes
internal/ioutil/ioutil_unix.go Outdated Show resolved Hide resolved
file_store.go Outdated Show resolved Hide resolved
file_store.go Outdated Show resolved Hide resolved
file_store.go Show resolved Hide resolved
@Wwwsylvia
address comments
7b9d4a1 
Signed-off-by: Sylvia Lei <[email protected]>
shizhMSFT
shizhMSFT reviewed Apr 13, 2023
View reviewed changes
file_store.go Outdated Show resolved Hide resolved
internal/ioutil/ioutil.go Outdated Show resolved Hide resolved
internal/ioutil/ioutil.go Outdated Show resolved Hide resolved
@Wwwsylvia
fix
b3f9fd5 
Signed-off-by: Sylvia Lei <[email protected]>
shizhMSFT
shizhMSFT suggested changes Apr 13, 2023
View reviewed changes
internal/ioutil/ioutil.go Outdated Show resolved Hide resolved
@Wwwsylvia
check close error
571dba0 
Signed-off-by: Sylvia Lei <[email protected]>
@Wwwsylvia
fix error check
f3eaeb0 
Signed-off-by: Sylvia Lei <[email protected]>
shizhMSFT
shizhMSFT approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 87a3ee4 into oras-project:main Apr 14, 2023
@Wwwsylvia Wwwsylvia deleted the filestore branch April 14, 2023 06:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@binbin-li binbin-li binbin-li left review comments

@qweeah qweeah qweeah requested changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement File Store
6 participants
@Wwwsylvia @codecov-commenter @TerryHowe @qweeah @binbin-li @shizhMSFT