feat: support login #42
Conversation
wangxiaoxuan273
requested review from
shizhMSFT,
Wwwsylvia and
TerryHowe
as code owners
Signed-off-by: wangxiaoxuan273 <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #42 +/- ##
==========================================
+ Coverage 69.69% 72.30% +2.61%
==========================================
Files 1 2 +1
Lines 33 65 +32
==========================================
+ Hits 23 47 +24
- Misses 9 15 +6
- Partials 1 3 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
registry.go
Outdated
|
|
||
| // Login provides the login functionality with the given credentials. | ||
| func Login(ctx context.Context, store Store, registry remote.Registry, cred auth.Credential) error { | ||
| if err := registry.Ping(ctx); err != nil { |
There was a problem hiding this comment.
cred is never used in Ping().
There was a problem hiding this comment.
The word registry is a bit overloaded here although I don't have a better suggestion.
There was a problem hiding this comment.
The word
registryis a bit overloaded here although I don't have a better suggestion.
Registry is the proper name here.
There was a problem hiding this comment.
The word
registryis a bit overloaded here although I don't have a better suggestion.
reg might be good enough
There was a problem hiding this comment.
changed to reg
Signed-off-by: wangxiaoxuan273 <[email protected]>
registry.go
Outdated
|
|
||
| // Login provides the login functionality with the given credentials. | ||
| func Login(ctx context.Context, store Store, registry remote.Registry, cred auth.Credential) error { | ||
| if err := registry.Ping(ctx); err != nil { |
There was a problem hiding this comment.
The word registry is a bit overloaded here although I don't have a better suggestion.
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
registry.go
Outdated
|
|
||
| // Login provides the login functionality with the given credentials. | ||
| func Login(ctx context.Context, store Store, registry remote.Registry, cred auth.Credential) error { | ||
| if err := registry.Ping(ctx); err != nil { |
There was a problem hiding this comment.
The word
registryis a bit overloaded here although I don't have a better suggestion.
reg might be good enough
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Resolves #31