This repository has been archived by the owner on Apr 7, 2024. It is now read-only.
build: initialize go mod #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sylvia Lei <[email protected]>
shizhMSFT
suggested changes
Mar 21, 2023
Signed-off-by: Sylvia Lei <[email protected]>
Merged
shizhMSFT
reviewed
Mar 21, 2023
go.mod
Outdated
| @@ -0,0 +1,3 @@ | |||
| module github.com/oras-project/oras-credentials-go | |||
There was a problem hiding this comment.
Should it be oras.land/oras-credentials-go?
There was a problem hiding this comment.
What was the advantage of using oras.land ?
There was a problem hiding this comment.
OK. Should we also update oras.land website to support this? oras-project/oras-www#133
There was a problem hiding this comment.
@TerryHowe Let's make it consistent with oras.land/oras-go. We may need another issue to discuss if we need to change it to github.com/oras-project for all go module (e.g. oras-go, oras-credentials-go).
Signed-off-by: Sylvia Lei <[email protected]>
This was referenced Mar 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #8