This repository has been archived by the owner on May 15, 2024. It is now read-only.
Update persisted content version requirements #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Evenson <[email protected]>
SteveLasker
approved these changes
Sep 10, 2021
michaelb990
approved these changes
Sep 11, 2021
sajayantony
reviewed
Sep 13, 2021
| @@ -36,7 +36,7 @@ Both the `DRAFT` and the `RC` may include an optional number suffix to indicate | |||
|
|
|||
| The tag `AD` should never be used in a SemVer stability marker. `AD` is synonymous with the final release. | |||
|
|
|||
| Content persisted MUST be version specific via the use of the `"mediaType"` field to assure the specification version is not assumed. For example code implementing `oras-artifacts-spec-1.0.0.DRAFT1` must use `"mediaType": "application/vnd.cncf.oras.artifact.manifest.1.0.0-DRAFT1+json"`. | |||
| Content persisted MUST be version specific to the target version (eg oras-artifacts-spec-1.0.0) via the use of the `"mediaType"` field to assure the specification version is not assumed. For example code implementing `oras-artifacts-spec-1.0.0` must use `"mediaType": "application/vnd.cncf.oras.artifact.manifest.1.0.0+json"`. | |||
There was a problem hiding this comment.
This field has been removed from the manifest as per - #42 . I believe we can retitle this as
Content persisted MUST be version specific to the target version (eg oras-artifacts-spec-1.0.0).
For example code implementing `oras-artifacts-spec-1.0.0` must use
`Content-Type: application/vnd.cncf.oras.artifact.manifest.1.0.0+json` when uploading
the artifact manifest.
You can point to - https://github.com/opencontainers/distribution-spec/blob/162b5c95788bccddbd68e4a234e75524fc10dc68/spec.md#pushing-manifests.
There was a problem hiding this comment.
We can leave it as is since the descriptor does have a mediaType field so it might be ok.
sajayantony
approved these changes
Sep 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lachlan Evenson [email protected]