Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Doc error: OCI image manifest listed as an example of artifact manifest #104

Closed
m5i-work opened this issue Jun 21, 2022 · 2 comments · Fixed by #107
Closed

Doc error: OCI image manifest listed as an example of artifact manifest #104

m5i-work opened this issue Jun 21, 2022 · 2 comments · Fixed by #107

Comments

@m5i-work
Copy link

An OCI image manifest is not a valid artifact manifest. But it's listed in Example ORAS Artifact Manifests (the first item).

@SteveLasker @shizhMSFT Should we reference this file instead?
@shizhMSFT
Copy link
Contributor

shizhMSFT commented Jun 21, 2022 •
edited
Loading

/cc @FeynmanZhou @yizha1

SteveLasker added a commit to SteveLasker/artifacts-spec that referenced this issue Jul 1, 2022
@SteveLasker
Resolves issue oras-project#104
1a9a019 
Signed-off-by: Steve Lasker <[email protected]>
@SteveLasker SteveLasker mentioned this issue Jul 1, 2022
Merged
@SteveLasker
Copy link
Contributor

Thanks @m5i-work. This is a good clarification.
I didn't mean to imply the OCI Image is an ORAS Artifact manifest type. I just created an example for comparison, and then just listed each one.
See PR #107

SteveLasker added a commit that referenced this issue Jul 5, 2022
@SteveLasker
Resolves issue #104 (#107)
b7868b4 
Signed-off-by: Steve Lasker <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Doc Fix: Remove OCI Image as an example of Artifact Manifest SteveLasker/artifacts-spec
3 participants
@SteveLasker @m5i-work @shizhMSFT