-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.2 compatibility] Make an empty hash shift return nil #2980
[3.2 compatibility] Make an empty hash shift return nil #2980
Conversation
Thank you. Changes look good for me. Regarding the failed specs - will look at the issue soon. |
I am not able to push my changes into this remote branch because of the following error.
So this PR will be marked as merged when an internal PR is merged. |
The following test cases in test_array.rb fail now: - test_shift2 - test_shift_none
@andrykonchin I don't think we need to tag any failing specs. Those specs will fail in master because master targets Ruby 3.1. We should have a 3.2-upgrade branch that either changes the version number to 3.2.2 or runs all specs with |
I've canceled the merging workflow for this PR. Will discuss it with @eregon next week. AFAIK our current approach is to merge only not harmful changes introduced in the next (not supported yet) Ruby version. Both new features and bug fixes I would consider as not harmful TBH. And this PR looks like just fixing a bug. |
I discussed it with Andrii. CRuby chose to not backport this, so it's in 3.2 but not in 3.1.
@nirvdrum We never had version-upgrade branches, because it's unfeasible in terms of conflicts (especially for the import files from MRI part). Specs listed in |
#3039
Ruby 3.2 empty Hash, when
#shift
is applied returns anil
. This PR makes this update for truffleruby.