-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
const_source_location
returning empty values where MRI does not
#2833
Comments
This is an easy fix (#2835), interestingly we already recorded the SourceSection on RubyModule itself for interop, which is something Ruby doesn't have a way to query, but we missed to pass a node/SourceSection to |
Great. I was planning to pick this one up. I was hoping it was easy, but feared it might require parser changes. |
nirvdrum
pushed a commit
to Shopify/truffleruby
that referenced
this issue
Jan 30, 2023
sophie-kaleba
pushed a commit
to sophie-kaleba/truffleruby
that referenced
this issue
Feb 16, 2023
sophie-kaleba
pushed a commit
to sophie-kaleba/truffleruby
that referenced
this issue
Feb 16, 2023
eregon
added a commit
to ruby/spec
that referenced
this issue
Feb 27, 2023
john-heinnickel
pushed a commit
to thermofisher-jch/truffleruby
that referenced
this issue
Aug 16, 2023
seven1m
pushed a commit
to seven1m/ruby_spec
that referenced
this issue
Sep 2, 2023
sophie-kaleba
pushed a commit
to sophie-kaleba/truffleruby
that referenced
this issue
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm running into an issue booting Sorbet. It uses
const_source_location
to build up a path to the lib directory. This works fine on MRI as it returns the filename defining the module whereas TruffleRuby returns[]
.I've narrowed down the TruffleRuby issue to a simple reproduction (placed in a file named bad.rb):
On MRI, I get:
On TruffleRuby, I get:
I've looked at the issue briefly and it's due to the constants not having associated source sections. In that case, we have
const_source_location
return[]
.The text was updated successfully, but these errors were encountered: