-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"WeakMap key can't be an instance of Integer" breaks google-protobuf 3.15 #2267
Comments
Thanks for the great report! Right, this is a change from Ruby 2.7. CRuby 2.6 also disallowed such keys:
It's unclear why the example with the inline Gemfile does not fail on CRuby 2.6.6 though. |
Ah, this is why it works on CRuby 2.6: @norswap Could you look into this? |
This blocks us from using a newer |
I just started looking into it, I think it should be an easy fix. |
See for example oracle/truffleruby#2267 but I think really there's some other issues around headers - also see grpc#25060
Well, not that easy :) |
Hello there! 👋
I've been running a few experiments trying to run
ddtrace
with TruffleRuby.I found an incompatibility that breaks the latest
google-protobuf
gem.Example:
output on TruffleRuby:
It looks like MRI allows numbers as keys in
WeakMap
, but TruffleRuby doesn't:As usual, let me know if I can provide any more info :)
P.s.:
google-protobuf
= 3.14.0
seems to work fine so I'm using that as a workaround for now. The google-protobuf changes were done as part of protocolbuffers/protobuf#8184 .The text was updated successfully, but these errors were encountered: