Add Method#const_addeed.

oracle · Jun 8, 2023 · 20f253f · 20f253f
1 parent 7e07d2b
commit 20f253f
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -21,6 +21,7 @@ Compatibility:
 * Add `String#bytesplice` (#3039, @itarato).
 * Add `String#byteindex` and `String#byterindex` (#3039, @itarato).
 * Add implementations of `rb_proc_call_with_block`, `rb_proc_call_kw`, `rb_proc_call_with_block_kw` and `rb_funcall_with_block_kw` (#3068, @andrykonchin).
+* Add `Module#const_added` (#3039,  @itarato).
 
 Performance:
 

diff --git a/spec/truffleruby.next-specs b/spec/truffleruby.next-specs
@@ -21,3 +21,5 @@ spec/ruby/core/string/bytesplice_spec.rb
 
 spec/ruby/core/string/byteindex_spec.rb
 spec/ruby/core/string/byterindex_spec.rb
+
+spec/ruby/core/module/const_added_spec.rb
diff --git a/src/main/java/org/truffleruby/core/module/ModuleFields.java b/src/main/java/org/truffleruby/core/module/ModuleFields.java
@@ -30,6 +30,7 @@
 import org.truffleruby.RubyLanguage;
 import org.truffleruby.collections.ConcurrentOperations;
 import org.truffleruby.collections.ConcurrentWeakSet;
+import org.truffleruby.core.CoreLibrary;
 import org.truffleruby.core.encoding.Encodings;
 import org.truffleruby.core.encoding.TStringUtils;
 import org.truffleruby.core.kernel.KernelNodes;
@@ -483,7 +484,7 @@ private RubyConstant setConstantInternal(RubyContext context, Node currentNode,
                     return null;
                 }
             }
-            newConstant = newConstant(currentNode, name, value, autoload, previous);
+            newConstant = newConstant(context, currentNode, name, value, autoload, previous);
         } while (!ConcurrentOperations.replace(constants, name, previousEntry, new ConstantEntry(newConstant)));
 
         if (previousEntry != null) {
@@ -497,11 +498,18 @@ private RubyConstant setConstantInternal(RubyContext context, Node currentNode,
         return autoload ? newConstant : previous;
     }
 
-    private RubyConstant newConstant(Node currentNode, String name, Object value, boolean autoload,
+    private RubyConstant newConstant(RubyContext context, Node currentNode, String name, Object value, boolean autoload,
             RubyConstant previous) {
         final boolean isPrivate = previous != null && previous.isPrivate();
         final boolean isDeprecated = previous != null && previous.isDeprecated();
         final SourceSection sourceSection = currentNode != null ? currentNode.getSourceSection() : null;
+
+        final CoreLibrary coreLibrary = context.getCoreLibrary();
+        if (currentNode != null && coreLibrary != null && coreLibrary.isLoaded()) {
+            final RubySymbol constSymbol = context.getLanguageSlow().getSymbol(name);
+            RubyContext.send(currentNode, rubyModule, "const_added", constSymbol);
+        }
+
         return new RubyConstant(rubyModule, name, value, isPrivate, autoload, isDeprecated, sourceSection);
     }
 

diff --git a/src/main/ruby/truffleruby/core/module.rb b/src/main/ruby/truffleruby/core/module.rb
@@ -105,6 +105,9 @@ def prepend(*modules)
     self
   end
 
+  private def const_added(name)
+  end
+
   def const_defined?(name, inherit = true)
     Primitive.module_const_defined?(self, name, inherit, true)
   end