Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring to reduce sonar code smell fixes #4485

Merged
merged 18 commits into from
Nov 30, 2023
Merged

Refactoring to reduce sonar code smell fixes #4485

merged 18 commits into from
Nov 30, 2023

Conversation

ginoaugustine
Copy link
Member

Refactoring to reduce sonar code smell fixes

@ginoaugustine
Refactoring and sonar code smell fixes
78e0228 
Signed-off-by: Gino Augustine <[email protected]>
@ginoaugustine
junit fixes
e78caec 
Signed-off-by: Gino Augustine <[email protected]>
@ginoaugustine
junit fixes
7825e09 
Signed-off-by: Gino Augustine <[email protected]>
@ginoaugustine
Code Smell fixes
3d5f001 
Signed-off-by: Gino Augustine <[email protected]>
@ginoaugustine
junit fixes
faca6ec 
Signed-off-by: Gino Augustine <[email protected]>
@ginoaugustine
codesmell fixes
40d3d77 
Signed-off-by: Gino Augustine <[email protected]>
@ginoaugustine
codesmell fixes
727c002 
Signed-off-by: Gino Augustine <[email protected]>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 16, 2023
@ginoaugustine ginoaugustine marked this pull request as ready for review November 16, 2023 12:14
@ginoaugustine ginoaugustine requested a review from vladak November 16, 2023 12:30
@ginoaugustine
review comments
c231975 
Signed-off-by: Gino Augustine <[email protected]>
@ginoaugustine
Review comments
920b17f 
Signed-off-by: Gino Augustine <[email protected]>
@ginoaugustine
Plugin loader sonar fixes
9061e05 
Signed-off-by: Gino Augustine <[email protected]>
@ginoaugustine
Plugin loader sonar fixes
d2f62d1 
Signed-off-by: Gino Augustine <[email protected]>
vladak
vladak requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@vladak vladak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through all the changes, only have a bunch of comments.

@ginoaugustine
Review comments
ee5d39c 
Signed-off-by: Gino Augustine <[email protected]>
@ginoaugustine
Checkstyle fixes
fd6708a 
Signed-off-by: Gino Augustine <[email protected]>
@ginoaugustine
fix to retain log order in launderlogs
296904e 
Signed-off-by: Gino Augustine <[email protected]>
@ginoaugustine ginoaugustine requested a review from vladak November 29, 2023 16:43
@ginoaugustine
Adding Nullable annotation
4f5cbce 
Signed-off-by: Gino Augustine <[email protected]>
@ginoaugustine ginoaugustine requested a review from vladak November 30, 2023 03:01
vladak
vladak approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@vladak vladak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work !

@vladak vladak merged commit a305692 into oracle:master Nov 30, 2023
8 of 9 checks passed
@ginoaugustine ginoaugustine deleted the sonarcodesmellfix branch December 5, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladak vladak vladak approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ginoaugustine @vladak