Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync with internal repo #99

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Sync with internal repo #99

merged 3 commits into from
Oct 3, 2024

Conversation

piyush-tiwari
Copy link
Member

Commits added:

  1. Fix Update Logic for BackendSets and Listeners for Issue Listener is not reconfigured as HTTPS when a TLS certificate is added #90
  2. Add NSG Support for IngressClass for Issue Can not find any configuration for NSG or SecuriyList in IngressClassParameters #58
  3. Add delete-protection-enabled annotation for LB preservation on IngressClass delete for Issue Controller deletes existing LoadBalancer #91

@piyush-tiwari
fix update logic for BackendSets and Listeners
e64da97 
- For Listener sync, fix panic scenario when updating non-TLS configured Ingress to TLS-configured Ingress
- Split BackendSet update wrapper method into two - one for bulk updating backends and one for updating other details. This is done to enable updating to nil value for sslConfig.
@piyush-tiwari
add NSG Support for IngressClass
a83348c 
- Added NSG Support for IngressClassess via new annotation
- Fixed LB Shape update by replacing retryToken with etag
@piyush-tiwari
add delete-protection-enabled annotation for LB preservation on Ingre…
02337de 
…ssClass delete

- Add a new annotation to preserve LB on IngressClass delete - we clear NSG IDs, WAF, and default_ingress BackendSet associated with the LB
- Update UpdateNetworkSecurityGroups method to accept parameters instead of a request object to avoid code duplication
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 27, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11065496334

Details

  • 154 of 186 (82.8%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.8%) to 65.559%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/ingress/ingress.go 2 5 40.0%
pkg/loadbalancer/loadbalancer.go 54 60 90.0%
pkg/controllers/ingressclass/ingressclass.go 61 84 72.62%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/ingress/ingress.go 1 53.87%
pkg/loadbalancer/loadbalancer.go 2 70.99%
Totals Coverage Status
Change from base Build 10805743188: 0.8%
Covered Lines: 2564
Relevant Lines: 3911
💛 - Coveralls

@piyush-tiwari piyush-tiwari merged commit 4203ca3 into main Oct 3, 2024
4 checks passed
@piyush-tiwari piyush-tiwari mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirpai nirpai nirpai approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piyush-tiwari @coveralls @nirpai