Skip to content

Commit

Permalink
6.7 release
Browse files Browse the repository at this point in the history
  • Loading branch information
sharadraju committed Nov 18, 2024
1 parent 8a5855b commit ed14819
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion doc/src/release_notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ node-oracledb Release Notes
For deprecated and desupported features, see
:ref:`Deprecations and desupported features <deprecations>`.

node-oracledb `v6.7.0 <https://github.com/oracle/node-oracledb/compare/v6.6.0...v6.7.0>`__ (TBD)
node-oracledb `v6.7.0 <https://github.com/oracle/node-oracledb/compare/v6.6.0...v6.7.0>`__ (18 Nov 2024)
---------------------------------------------------------------------------------------------------------

Common Changes
Expand Down
14 changes: 7 additions & 7 deletions test/connection.js
Original file line number Diff line number Diff line change
Expand Up @@ -826,27 +826,27 @@ describe('1. connection.js', function() {

const conn = await oracledb.getConnection(dbaConfig);

// Whitespaces, comma, ( and ) are replaced by ? for the program name
// in V$SESSION
const sanitizedProgName = process.argv0.replace(/[\s(),]/g, '?');

// Fetch values from v$session
let res = await conn.execute(sqlSessionDetails);
assert.strictEqual(res.rows[0][0], os.hostname());
assert.strictEqual(res.rows[0][1], os.userInfo().username);
assert.strictEqual(res.rows[0][2], 'unknown');
// Whitespaces, ( and ) are replaced by ? for the program name
// in V$SESSION
assert.strictEqual(res.rows[0][3], process.argv0.replace(/[\s()]/g, '?'));
assert.strictEqual(res.rows[0][3], sanitizedProgName);

if (dbConfig.test.drcp) {
const bindParams = {
machine: os.hostname(),
terminal: 'unknown',
program: process.argv0
program: sanitizedProgName
};
res = await conn.execute(sqlDRCPSessionDetails, bindParams);
assert.deepStrictEqual(res.rows[0][0], os.hostname());
assert.deepStrictEqual(res.rows[0][1], 'unknown');
// Whitespaces, ( and ) are replaced by ? for the program name
// in V$SESSION
assert.deepStrictEqual(res.rows[0][2], process.argv0.replace(/[\s()]/g, '?'));
assert.deepStrictEqual(res.rows[0][2], sanitizedProgName);
}

res = await conn.execute(sqlDriverName);
Expand Down

0 comments on commit ed14819

Please sign in to comment.