Add support for Netty 4.1.115+ #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds additional reflection metadata for MpscUnpaddedArrayQueueConsumerIndexField, MpscUnpaddedArrayQueueProducerIndexField and MpscUnpaddedArrayQueueProducerLimitField in the io.netty.util.internal.shaded.org.jctools.queues.unpadded package. It also refines the metadata with a "default-for" entry that ensures that previous metadata continue to be used for Netty 4.1.0 to 4.1.114, uses consistently Netty 4.1.80 for the tests of the previous version, and adds related tests for Netty 4.1.115.
|
Thanks @sdeleuze, that looks good to me. |
mhalbritter
approved these changes
Nov 15, 2024
fniephaus
approved these changes
Nov 15, 2024
|
@zakkak as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds additional reflection metadata for
MpscUnpaddedArrayQueueConsumerIndexField,MpscUnpaddedArrayQueueProducerIndexFieldandMpscUnpaddedArrayQueueProducerLimitFieldin theio.netty.util.internal.shaded.org.jctools.queues.unpaddedpackage.It also refines the metadata with a "default-for" entry that ensures that previous metadata continue to be used for Netty 4.1.0 to 4.1.114, uses consistently Netty 4.1.80 for the tests of the previous version, and adds related tests for Netty 4.1.115.