Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add testcontainers/ryuk:0.10.2 to allowed images list #547

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Kehrlann
Copy link
Contributor

@Kehrlann Kehrlann commented Oct 11, 2024

What does this PR do?

Add testcontainers/ryuk:0.10.2 to allowed images list. No grype failures detected as of 2024-10-11:

$ grype testcontainers/ryuk:0.10.2
 ✔ Vulnerability DB                [updated]  
 ✔ Pulled image                    
 ✔ Loaded image                                                                                   testcontainers/ryuk:0.10.2
 ✔ Parsed image                                      sha256:61474639f5c88956870c4e99f4c00ba9f003ef0998fd31490fea9aebdc4f8679
 ✔ Cataloged contents                                       3930e92afc1cc6e6b7a91c973db3d63f9eccc2a713667c7d6fa7acf5a4bd1770
   ├── ✔ Packages                        [34 packages]  
   ├── ✔ File digests                    [230 files]  
   ├── ✔ File metadata                   [230 locations]  
   └── ✔ Executables                     [20 executables]  
 ✔ Scanned for vulnerabilities     [0 vulnerability matches]  
   ├── by severity: 0 critical, 0 high, 0 medium, 0 low, 0 negligible
   └── by status:   0 fixed, 0 not-fixed, 0 ignored 
No vulnerabilities found

Code sections where the PR accesses files, network, docker or some external service

n/a

Checklist before merging

Not applicable:

@Kehrlann Kehrlann requested a review from matneu as a code owner October 11, 2024 09:32
@Kehrlann Kehrlann mentioned this pull request Oct 11, 2024
6 tasks
@Kehrlann Kehrlann force-pushed the dockerfile-testcontainers-ryuk branch from 768d92d to a90822a Compare October 17, 2024 08:22
@Kehrlann Kehrlann changed the title add testcontainers/ryuk:0.10.1 to allowed images list add testcontainers/ryuk:0.10.2 to allowed images list Oct 17, 2024
@Kehrlann
Copy link
Contributor Author

Updated to ryuk:0.10.2 which brings bugfixes around the lifecycle of the image.

@matneu
Copy link
Member

matneu commented Nov 4, 2024

What is ryuk required for?

@Kehrlann
Copy link
Contributor Author

Kehrlann commented Nov 4, 2024

Hey @matneu!

Ryuk is Testcontainer's "garbage collector" docker image, that reaps unused containers when they are unused. While containers may be stopped manually, Ryuk is part of the default setup of Testcontainers and ensures containers are cleaned up. It's mentioned in this section of their docs: https://testcontainers.com/getting-started/#benefits-of-using-testcontainers .
It is used by tests in #546

Note that test could run without Ryuk but would not represent the default usage of the library.

@Kehrlann Kehrlann closed this Nov 4, 2024
@Kehrlann Kehrlann reopened this Nov 4, 2024
@Kehrlann Kehrlann force-pushed the dockerfile-testcontainers-ryuk branch from a90822a to 083e8a7 Compare November 4, 2024 19:43
@dnestoro dnestoro merged commit 3e78314 into oracle:master Nov 5, 2024
225 checks passed
@Kehrlann Kehrlann deleted the dockerfile-testcontainers-ryuk branch November 5, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants