Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'latest' key from index.json for itext metadata #500

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

vitali-pr
Copy link
Contributor

Starting from 8.0.4 itext core includes reachability metadata into library.

What does this PR do?

Looking at https://www.graalvm.org/native-image/libraries-and-frameworks/ it seems there is a redundancy in terms of supported versions of itext core libs. I believe removing 'latest' key from index.json should remove '8.0.3 - latest' range from the page above and leave only 8.0.3. Though I don't see any similar example in the whole repo so not sure.

Checklist before merging

Starting from 8.0.4 itext core includes reachability metadata into library.
@vitali-pr vitali-pr requested a review from a team as a code owner May 28, 2024 09:07
@vitali-pr vitali-pr requested a review from msupic May 28, 2024 09:07
@vitali-pr
Copy link
Contributor Author

@msupic , it's hanging for quite some time already. Could you, please have a look?

@msupic
Copy link
Contributor

msupic commented Jun 6, 2024

@dnestoro - I will not have time to review this so if you or somebody else can review it would be great.

@msupic msupic removed their request for review June 6, 2024 08:37
@dnestoro
Copy link
Member

I am not sure what to do in this case. @fniephaus since you are more familiar with libraries-and-frameworks list, what do you think?

@fniephaus fniephaus self-assigned this Jun 14, 2024
@fniephaus
Copy link
Member

Thanks for bringing this to our attention, @vitali-pr. I'm not sure we really need to change the metadata but the changes you suggest look reasonable to me. Anyway, it will not automatically solve the double listing on the graalvm.org website. Let me take a look next week and see how we can improve the website. Maybe this change is actually not needed, in which case it may be better to delay the changes until they are really needed. :)

Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! We are going to update the website very soon

@fniephaus fniephaus merged commit ec37ed0 into oracle:master Aug 23, 2024
6 checks passed
@fniephaus
Copy link
Member

We have improved the website and it now shows, for example, this:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants