Add initial support for hibernate-orm:hibernate-core:6.5.0.Final #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophstrobl
force-pushed
the
hibernate-orm-core/6.5.0.CR1
branch
from
3e7e7ae to
ee8d745
Compare
|
Hibernate 6.5 has been released (hibernate-orm:6.5.0.Final )- will update the PR with new version. |
Move over and adapt tests from hibernate 6.2 to generate metadata via generate-metadata script. Fixed compilation issues and removed no longer supported dialects. Updated metadata generation to include Logger setup. Updated metadata filter to ignore hibernate internal code generation facilities.
the bytecode provider property is no longer supported so we need to bypass the default implementation to avoid failures with bytebuddy.
christophstrobl
force-pushed
the
hibernate-orm-core/6.5.0.CR1
branch
from
ee8d745 to
2c24c98
Compare
christophstrobl
changed the title
msupic
approved these changes
Apr 29, 2024
| @@ -0,0 +1,2 @@ | |||
| hibernate.bytecode.provider=none | |||
There was a problem hiding this comment.
Can this file be deleted since these properties are not read in this version of hibernate?
There was a problem hiding this comment.
yeah, sorry - overlooked that one
sdeleuze
reviewed
Apr 30, 2024
|
Tested with Petclinic, Spring Boot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move over and adapt tests from hibernate 6.2 to generate metadata via
generate-metadata.shscript.Fixed compilation issues and removed no longer supported dialects.
Updated metadata generation to include Logger setup.
Updated metadata filter to ignore hibernate internal code generation facilities.
Checklist before merging
A: Given the metadata already resides in this repository I think it's fine to adapt for newer versions of the target library.
A: Actually I copied existing tests form this repository to a new directory and modified them so they run with the updated version of the library.
A: Well those are copies of existing tests in the very same repository & license.