Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional metadata for ch.qos.logback:logback-classic:1.4.1 #372

Merged
merged 8 commits into from
Sep 29, 2023

Conversation

msupic
Copy link
Contributor

@msupic msupic commented Aug 18, 2023

What does this PR do?

Adds more metadata for ch.qos.logback:logback-classic:1.4.1 and ch.qos.logback:logback-classic:1.4.9

Code sections where the PR accesses files, network, docker or some external service

Checklist before merging

@msupic msupic requested a review from a team as a code owner August 18, 2023 14:13
@msupic msupic requested a review from vjovanov August 18, 2023 14:13
@fniephaus fniephaus requested review from bclozel and dnestoro and removed request for vjovanov September 4, 2023 12:57
@bclozel
Copy link
Collaborator

bclozel commented Sep 4, 2023

I'm a bit hesitant about this one. This adds a lot of reflection for features that most users won't use (HTML logging?). The reachability trigger is also quite broad with LayoutBase. I'm aware that given the XML nature of the configuration we might not have better signals for those, but I'm worries that this change adds significant weight to most native images for cases that are a bit niche.

@bclozel bclozel mentioned this pull request Sep 4, 2023
6 tasks
@msupic
Copy link
Contributor Author

msupic commented Sep 4, 2023

I wanted to cover as mush as possible cases so we don't have to change these metadata often. Anyway I can remove some cases, for example:

  • EchoLayout
  • TTLLLayout
  • HTMLLayout

@msupic msupic merged commit 3b0f995 into master Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants