-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust docker and grype tasks #355
Merged
dnestoro
merged 11 commits into
oracle:master
from
dnestoro:dnestoro/AdjustDockerAndGrypeTasks
Jul 26, 2023
Merged
Adjust docker and grype tasks #355
dnestoro
merged 11 commits into
oracle:master
from
dnestoro:dnestoro/AdjustDockerAndGrypeTasks
Jul 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fniephaus
requested changes
Jul 25, 2023
tests/tck-build-logic/src/main/java/org/graalvm/internal/tck/DockerUtils.java
Show resolved
Hide resolved
tests/tck-build-logic/src/main/java/org/graalvm/internal/tck/DockerUtils.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Fabio Niephaus <[email protected]>
Co-authored-by: Fabio Niephaus <[email protected]>
Co-authored-by: Fabio Niephaus <[email protected]>
Co-authored-by: Fabio Niephaus <[email protected]>
fniephaus
reviewed
Jul 25, 2023
tests/tck-build-logic/src/main/java/org/graalvm/internal/tck/DockerUtils.java
Outdated
Show resolved
Hide resolved
dnestoro
force-pushed
the
dnestoro/AdjustDockerAndGrypeTasks
branch
from
July 25, 2023 14:29
c578917
to
3ba5c62
Compare
fniephaus
reviewed
Jul 25, 2023
tests/tck-build-logic/src/main/java/org/graalvm/internal/tck/DockerUtils.java
Outdated
Show resolved
Hide resolved
fniephaus
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the swift resolution :)
Co-authored-by: Fabio Niephaus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a follow-up PR of this PR. It removes usage of
AllowedDockerImages.txt
and introduces a new way we are collecting allowed docker images list.Checklist before merging
n/a