Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Native Build Tools and update to GraalVM for JDK 17. #322

Merged
merged 4 commits into from
Jun 23, 2023

Conversation

fniephaus
Copy link
Member

What does this PR do?

This PR upgrade the NBT to 0.9.23 and updates all uses of the setup-graalvm action to use the new GraalVM for JDK 17 release.

Checklist before merging

n/a

@fniephaus fniephaus requested a review from dnestoro June 22, 2023 10:01
@fniephaus fniephaus self-assigned this Jun 22, 2023
@fniephaus fniephaus requested a review from a team as a code owner June 22, 2023 10:01
@@ -91,10 +91,9 @@ if (project.hasProperty("baseCommit")) {

def matrixDefault = [
"versions" : [
[ "graalvm": "dev", "java": "17" ],
[ "graalvm": "latest", "java": "17" ]
[ "java": "17" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need this extra subsection. Since we don't use pairs anymore, we can remove "java", and use simple array as it is the case for os. And then change matrix.versions.java -> matrix.versions here as we do for matrix.os

@fniephaus fniephaus force-pushed the fniephaus/update branch 2 times, most recently from 8fb1d2b to 428863f Compare June 23, 2023 08:32
The Gradle toolchain detection has issues detecting GraalVM installation. The toolchain detection will be revamped, disable it here for now.
@fniephaus fniephaus requested a review from melix June 23, 2023 10:46
@fniephaus fniephaus merged commit 475a68f into master Jun 23, 2023
@fniephaus fniephaus deleted the fniephaus/update branch June 23, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants