-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Not Supported Java Version Bug #203
Fix Not Supported Java Version Bug #203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this is not that easy.
If this is later used for graalvm/setup-graalvm
action, the valid combinations are:
version: latest
, java-version: 17` (should remove hardcoded 22.3.0 version and use latest)version: dev
, java-version: dev` (see Allowjava-version: 'dev'
for GraalVM dev builds graalvm/setup-graalvm#31).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://docs.gradle.org/current/release-notes.html#java19 , increasing the Gradle version used by the project to 7.6 is a requirement for JDK19 testing.
I have to explore how to implement that. Thanks for the suggestion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I think https://github.com/oracle/graalvm-reachability-metadata/blob/master/gradle/wrapper/gradle-wrapper.jar should be removed instead of keeping a copy of the old 7.4.1 binary in Git.
-
We should also add
**/gradle/wrapper/gradle-wrapper.jar
entry in.gitignore
and remove!gradle-wrapper.jar
entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
According to https://github.com/oracle/graalvm-reachability-metadata/actions/runs/4016627730/jobs/6900250113 , it seems that when
org.jetbrains.kotlin-kotlin-reflect-1.7.10
detects itself running on JDK19 , will automatically block tests, it seems that need add@Disabled
annotations to all its unit tests temporarily? Cc @mhalbritter , the original committer of this unit test. -
https://github.com/oracle/graalvm-reachability-metadata/actions/runs/4016627730/jobs/6900237366 shows that
org.eclipse.jetty-jetty-server-11.0.12
is calling the JDK19 Virtual Thread class, which it is so weird, I can't see the relevant operations in the unit test. -
It looks like we have to temporarily change the
build.gradle
plugin settings in https://github.com/oracle/graalvm-reachability-metadata/blob/master/tests/src/org.eclipse.jetty/jetty-server/11.0.12/build.gradle .
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
0bd8983
to
246bcec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
As discussed with @fniephaus we will disable JDK19 builds temporarily, to unblock CI. Builds will be enabled again, as soon as we define the best solution for the problem. |
|
What does this PR do?
Fix Ci
not supported Java version
error.