Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Not Supported Java Version Bug #203

Merged

Conversation

dnestoro
Copy link
Member

What does this PR do?

Fix Ci not supported Java version error.

@dnestoro dnestoro requested a review from a team as a code owner January 25, 2023 13:08
@dnestoro dnestoro requested a review from msupic January 25, 2023 13:08
@dnestoro dnestoro marked this pull request as draft January 25, 2023 13:30
Copy link
Member

@alvarosanchez alvarosanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this is not that easy.

If this is later used for graalvm/setup-graalvm action, the valid combinations are:

Copy link
Contributor

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://docs.gradle.org/current/release-notes.html#java19 , increasing the Gradle version used by the project to 7.6 is a requirement for JDK19 testing.

@dnestoro
Copy link
Member Author

It seems this is not that easy.

If this is later used for graalvm/setup-graalvm action, the valid combinations are:

  • version: latest, java-version: 17` (should remove hardcoded 22.3.0 version and use latest)
  • version: dev, java-version: dev` (see graalvm/setup-graalvm#31).

I have to explore how to implement that. Thanks for the suggestion

Copy link
Contributor

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnestoro dnestoro marked this pull request as ready for review January 27, 2023 09:49
@dnestoro dnestoro requested a review from fniephaus January 27, 2023 09:50
@dnestoro dnestoro force-pushed the dnestoro/FixNotSupportedJavaVersion branch from 0bd8983 to 246bcec Compare January 27, 2023 10:17
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dnestoro
Copy link
Member Author

As discussed with @fniephaus we will disable JDK19 builds temporarily, to unblock CI. Builds will be enabled again, as soon as we define the best solution for the problem.

@linghengqian
Copy link
Contributor

As discussed with @fniephaus we will disable JDK19 builds temporarily, to unblock CI. Builds will be enabled again, as soon as we define the best solution for the problem.

  • Once this PR is merged, I can try to fix JDK 19 related unit tests in another PR. I have a PR addressing issues with Jetty Server, Jetty Client and Kotlin Reflect.

@dnestoro dnestoro merged commit 3fbec45 into oracle:master Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants