Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check in diffCordinates function #172

Merged

Conversation

dnestoro
Copy link
Member

What does this PR do?

As reported in this gate there is an attempt to create a stream over the element which is null(we don't have null check for element we are trying to get from map). @melix please check if the fix can break something else in your logic here, since you are more familiar with this part of the code.

@dnestoro dnestoro requested review from melix and vjovanov January 13, 2023 14:43
Copy link
Member

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not particularly familiar with this code, actually (it was written by Lazar) but the change LGTM

@vjovanov vjovanov merged commit f08414c into oracle:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants