-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for com.github.luben:zstd-jni:1.5.2-5
#121
Conversation
.../com.github.luben/zstd-jni/1.5.2-5/src/test/java/com_github_luben/zstd_jni/Zstd_jniTest.java
Show resolved
Hide resolved
metadata/com.github.luben/zstd-jni/1.5.2-5/resource-config.json
Outdated
Show resolved
Hide resolved
metadata/com.github.luben/zstd-jni/1.5.2-5/resource-config.json
Outdated
Show resolved
Hide resolved
7070378
to
ed19fcf
Compare
c44effd
to
6e96feb
Compare
LGTM! |
3af6c15
to
04375b0
Compare
@Test | ||
void testCompressFile() throws IOException { | ||
File file = new File("src/test/resources/originTest.txt"); | ||
File outFile = new File("src/test/resources/originTest.txt.zs"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be worth writing these files to a temporary directory so that they don't pollute the main repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Do you mean let me replace it with
java.io.File.createTempFile
, and replace the tailassertDoesNotThrow(outFile::delete);
withassertDoesNotThrow(outFile::deleteOnExit);
? Do I need to keep committing to this PR or?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly. I would commit the change to this PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this done?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this done?
@gradinac Any updates?
Could we also remove the merge commit from the history? |
|
4999878
to
e138b4f
Compare
|
Looks good now, only one commit. |
What does this PR do?
com.github.luben:zstd-jni:1.5.2-5
#120 .Checklist before merging