Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for hibernate-validator #12

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

mhalbritter
Copy link
Collaborator

@mhalbritter mhalbritter commented Jul 26, 2022

Signed-off-by: Moritz Halbritter [email protected]

What does this PR do?

Adds metadata for hibernate validator. The readme in the tests explains how these files have been generated.

Checklist before merging

  • I have properly formatted metadata files (see CONTRIBUTING document)
  • I have added thorough tests. (see this)

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 26, 2022
Copy link
Contributor

@lazar-mitrovic lazar-mitrovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you are missing metadata/index.json entry for this library.
This won't be necessary after #1 is merged, but for now tests won't be triggered unless this is fixed.

@mhalbritter mhalbritter force-pushed the mh/hibernate-validator branch from e08dae8 to 84dbbeb Compare July 28, 2022 12:56
@mhalbritter
Copy link
Collaborator Author

Thanks. I have updated the PR.

@mhalbritter
Copy link
Collaborator Author

Ah, i used Java 17 features. I will update to only use Java 11 features.

Signed-off-by: Moritz Halbritter <[email protected]>
@mhalbritter mhalbritter force-pushed the mh/hibernate-validator branch from 84dbbeb to 165fa88 Compare August 1, 2022 07:41
@mhalbritter
Copy link
Collaborator Author

Done, please approve to let the CI run, thanks :)

@lazar-mitrovic lazar-mitrovic merged commit 9ee8f5d into oracle:master Aug 4, 2022
@mhalbritter mhalbritter deleted the mh/hibernate-validator branch August 5, 2022 06:53
@mhalbritter
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants