Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a first list of supported libraries #119

Merged
merged 5 commits into from
Dec 5, 2022
Merged

Provide a first list of supported libraries #119

merged 5 commits into from
Dec 5, 2022

Conversation

sdeleuze
Copy link
Collaborator

Provide a first list of supported libraries and make tests-locations optional.

@fniephaus fniephaus self-assigned this Dec 1, 2022
fniephaus
fniephaus approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @sdeleuze!

fniephaus
fniephaus reviewed Dec 1, 2022
View reviewed changes
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I just realized this removes tests_locations from the required list of keys. Let's discuss this in our next meeting on Monday.

@fniephaus fniephaus self-requested a review December 1, 2022 15:17
@fniephaus fniephaus merged commit acd6846 into oracle:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fniephaus fniephaus fniephaus approved these changes

Assignees

@fniephaus fniephaus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdeleuze @fniephaus