-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata for Netty MacOS specific nameserver resolution #103
Conversation
Netty provides MacOS specific nameserver resolution - resolver-dns-classes-macos and resolver-dns-native-macos. The exception below is observed when there is no metadata for this functionality: ``` java.lang.NoSuchMethodException: io.netty.resolver.dns.macos.MacOSDnsServerAddressStreamProvider.<init>() at [email protected]/java.lang.Class.getConstructor0(DynamicHub.java:3641) ~[client:na] at [email protected]/java.lang.Class.getConstructor(DynamicHub.java:2324) ~[client:na] at io.netty.resolver.dns.DnsServerAddressStreamProviders.<clinit>(DnsServerAddressStreamProviders.java:63) ~[na:na] at io.netty.resolver.dns.DnsNameResolverBuilder.<init>(DnsNameResolverBuilder.java:60) ~[na:na] ``` Closes #100
@dnestoro Thanks a lot! |
Hey, during some checking I realized that some of the entries in Entries: both this and this |
@dnestoro We do have in Reactor Netty a smoke test for all OS. What would be the best way for testing the proposed change? Provide a local metadata repository instead of the original? |
Can you manually change |
ok I'll try |
@dnestoro The proposal seems to be working I made some changes to the test in order to test Mac OS natives. |
What does this PR do?
Netty provides MacOS specific nameserver resolution -
resolver-dns-classes-macos
andresolver-dns-native-macos
.The PR adds metadata for Netty MacOS specific nameserver resolution.
The exception below is observed when there is no metadata for this functionality:
Closes #100
Checklist before merging
Test is not provided because the fix is relevant only for MacOS.