-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a default-for
attribute
#62
Labels
enhancement
New feature or request
Comments
7 tasks
This was referenced Apr 27, 2023
sdeleuze
added a commit
to sdeleuze/graalvm-reachability-metadata
that referenced
this issue
Apr 28, 2023
This new index.json attribute is design to allow more flexible version matching to avoid breakage due to switch on latest version for untested ones. It should have a `default-for` key and a regexp as a string value, for example "1\\.0\\..*" which should match versions like "1.0.0", "1.0.1", "1.0.2", etc. Closes oracle#62
sdeleuze
added a commit
to sdeleuze/graalvm-reachability-metadata
that referenced
this issue
Apr 28, 2023
This new index.json attribute is design to allow more flexible version matching to avoid breakage due to switch on latest version for untested ones. It should have a `default-for` key and a regexp as a string value, for example "1\\.0\\..*" which should match versions like 1.0.0, 1.0.1, 1.0.2, etc. Closes oracle#62
sdeleuze
added a commit
to sdeleuze/graalvm-reachability-metadata
that referenced
this issue
Apr 28, 2023
This new index.json attribute is designed to allow more flexible version matching to avoid breakage due to switching on the latest version for untested ones. It should have a `default-for` key and a regexp as a string value, for example "1\\.0\\..*" which should match versions like 1.0.0, 1.0.1, 1.0.2, etc. Closes oracle#62
sdeleuze
added a commit
to sdeleuze/native-build-tools
that referenced
this issue
Apr 28, 2023
This new index.json attribute is design to allow more flexible version matching to avoid breakage due to switch on latest version for untested ones. It should have a `default-for` key and a regexp as a string value, for example "1\\.0\\..*" which should match versions like "1.0.0", "1.0.1", "1.0.2", etc. See oracle/graalvm-reachability-metadata#62 See oracle/graalvm-reachability-metadata#275
Related NBT PR is graalvm/native-build-tools#432. |
dnestoro
pushed a commit
that referenced
this issue
May 3, 2023
This new index.json attribute is designed to allow more flexible version matching to avoid breakage due to switching on the latest version for untested ones. It should have a `default-for` key and a regexp as a string value, for example "1\\.0\\..*" which should match versions like 1.0.0, 1.0.1, 1.0.2, etc. Closes #62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
latest
attribute seems not robust enough since it does not manage any notion of semantic versioning.For example, I am going to add metadata for
ch.qos.logback:logback-classic 1.4.1
with thelatest
flag set totrue
. Once Logback1.2.12
will be out and used by somebody, native compilation will be broken due to the default to the latest if we just have metadata for1.2.11
.As discussed with @melix, we could introduce a
default-for
attribute with a regexp value used to match the version of the dependency.latest
would translate to"default-for": ".*"
, and we could document and use regexp for matching the same major + major version, which would be the most common use case.The text was updated successfully, but these errors were encountered: