Don't ignore days in timedelta when converting to TimeZone #360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to create a date in
US/New_York
timezone and convert it into Java fails. This was reported to Enso by our US based developer: enso-org/enso#7655 - the final exception is:I have investigated the issue and I am providing a test to simulate the problem as well as a possible fix. the issue is that running:
yields
e.g. the value of seconds field is bigger than allowed -18:00 and +18:00. My fix also reads value of
days
which is (in this case)-1
and compensates the value to fit into the desired range.