Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Records & Tuples Proposal Implementation #433

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

christianaistleitner
Copy link

@christianaistleitner christianaistleitner commented Apr 1, 2021

ready for review

@graalvmbot
Copy link
Collaborator

Hello Christian Aistleitner, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address christian -(dot)- aistleitner -(at)- outlook -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

@wirthi wirthi requested review from woess and wirthi April 2, 2021 10:23
@christianaistleitner christianaistleitner marked this pull request as ready for review April 16, 2021 13:02
# Conflicts:
#	graal-js/src/com.oracle.js.parser/src/com/oracle/js/parser/TokenType.java
#	graal-js/src/com.oracle.truffle.js.parser/src/com/oracle/truffle/js/parser/GraalJSTranslator.java
#	graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/access/ReadElementNode.java
#	graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/control/DeletePropertyNode.java
@graalvmbot
Copy link
Collaborator

Christian Aistleitner has signed the Oracle Contributor Agreement (based on email address christian -(dot)- aistleitner -(at)- outlook -(dot)- com) so can contribute to this repository.

Copy link
Member

@wirthi wirthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks great already! Thanks for implementing that.

A few things noted in the review, but nothing major so far, just comments around proper usage of Truffle and making sure this compiles nicely and produces fast code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants