Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce reasons attribute in json configuration schemas #8962

Closed
wants to merge 1 commit into from

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented May 23, 2024

Closes #8543

cc @fniephaus

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 23, 2024
@zakkak zakkak force-pushed the 2024-05-23-fix-8543 branch from ca74ebd to bca52e1 Compare May 23, 2024 12:32
@fniephaus fniephaus requested a review from vjovanov May 31, 2024 08:12
@vjovanov
Copy link
Member

vjovanov commented Jun 5, 2024

Hi @zakkak, thanks for submitting this PR. We are currently undergoing an overhaul of the reachability metadata. In this effort we consolidate all metadata entries into a single file (rechability-metadata.json):

#9048

The new file contains both reason and comment. Would the implementation in the given proposal work for your needs?

@zakkak
Copy link
Collaborator Author

zakkak commented Jun 6, 2024

Hi @vjovanov, yes I had a quick look over the new schema and it looks fine, except for a comment I added about reason. Closing this as superseded by #9048. Thanks for the heads up.

@zakkak zakkak closed this Jun 6, 2024
@zakkak zakkak deleted the 2024-05-23-fix-8543 branch June 6, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GR-52611] Add the ability to add comments to JSON configuration file entries
2 participants