Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-41912] More user-friendly reporting of internal errors. #5414

Closed
wants to merge 2 commits into from

Conversation

graalvmbot
Copy link
Collaborator

@graalvmbot graalvmbot commented Nov 11, 2022

In case of internal errors, the build process generates an error report and no longer shows daunting stack traces. Instead, it fails with a clear message that tells users how to proceed: inspect the error report and, if unable to resolve the problem, file an issue with the error report.

Inspired by HotSpot, the default filename for error reports is ./svm_err_b_<timestamp>_pid<pid>.md.

This PR also adds a new HotSpot-inspired option: ErrorFile lets you choose a different filename for error reports.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 11, 2022
@fniephaus fniephaus self-assigned this Nov 11, 2022
@fniephaus fniephaus changed the title [GR-41912] Make reporting of fatal errors more user-friendly. [GR-41912] Make reporting of internal errors more user-friendly. Nov 14, 2022
@fniephaus fniephaus changed the title [GR-41912] Make reporting of internal errors more user-friendly. [GR-41912] More user-friendly reporting of internal errors. Nov 14, 2022
@graalvmbot graalvmbot force-pushed the fniephaus/GR-41912/vmerror-reports branch from e8e5720 to 9ecdd9c Compare November 14, 2022 13:25
In case of internal errors, the build process generates an error report
and no longer shows daunting stack traces. Instead, it fails with a
clear message that tells users how to proceed: inspect the error report
and, if unable to resolve the problem, file an issue with the error
report.

Inspired by HotSpot, the default filename for error reports is
`./svm_err_<timestamp>_pid<pid>.md`.
@graalvmbot graalvmbot force-pushed the fniephaus/GR-41912/vmerror-reports branch from 9ecdd9c to 3fb4562 Compare November 14, 2022 13:35
@graalvmbot graalvmbot closed this Jan 3, 2023
@graalvmbot graalvmbot deleted the fniephaus/GR-41912/vmerror-reports branch January 3, 2023 13:14
@fniephaus fniephaus added this to the 23.0.0 Release milestone Feb 1, 2023
@fniephaus
Copy link
Member

This was merged via e922d61.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

2 participants