[GR-33955] Handle bundle instances in the heap in the localization optimized mode. #3956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graalvmbot
force-pushed
the
github/d-kozak/GR-33955/basicxmlparserstest_testerrormessage-is-broken
branch
from
7b25f37 to
3592e6c
Compare
pejovica
approved these changes
Oct 28, 2021
graalvmbot
force-pushed
the
github/d-kozak/GR-33955/basicxmlparserstest_testerrormessage-is-broken
branch
from
3592e6c to
18e5660
Compare
graalvmbot
deleted the
github/d-kozak/GR-33955/basicxmlparserstest_testerrormessage-is-broken
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the OptimizedLocalizationSupport the bundles are stored in a map. In order to make the getContents methods unreachable, the bundles are initialized eagerly and the lookup methods are substituted. However, if there are bundle instances somewhere in the heap that were not put in the map, they won't be initialized and therefore accessing their content will cause runtime failures. Therefore, we visit each object in the heap and if it is a ResourceBundle, we eagerly initialize it.