-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native image bash launcher version and vm config #3329
Native image bash launcher version and vm config #3329
Conversation
Hi @olpaw, can you please review this? We would also like this to get backported to Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Glad we found something that works well for both of us.
substratevm/src/com.oracle.svm.driver/src/com/oracle/svm/driver/DefaultOptionHandler.java
Outdated
Show resolved
Hide resolved
b45da10
to
4608618
Compare
Your PR just merged on master (should be visible in a few minutes). I also created a PR against 21.1 and it should get included there as well. |
Thank you Paul! |
…errypicked for 21.1. PullRequest: graal/8719
The change also got included in the release branch (on Apr 9, 2021): https://github.com/oracle/graal/commits/release/graal-vm/21.1 |
…vm config #3329. PullRequest: graal/9484
As discussed in graalvm#230 and #3313 in 21.1-dev the
native-image
bash-launcher no longer prints a meaningful version.This PR makes the bash launcher print:
for GraalVM CE and
for Mandrel.
The corresponding native
native-image
binaries print:for GraalVM CE and
for Mandrel.