Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native image bash launcher version and vm config #3329

Merged
merged 2 commits into from
Apr 9, 2021

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Apr 7, 2021

As discussed in graalvm#230 and #3313 in 21.1-dev the native-image bash-launcher no longer prints a meaningful version.

This PR makes the bash launcher print:

native-image 21.1.0 Java 11 CE (Java Version 11.0.11+5-jvmci-21.1-b02)

for GraalVM CE and

native-image 21.1.0.0 Java 11 Mandrel Distribution (Java Version 11.0.10+9)

for Mandrel.

The corresponding native native-image binaries print:

GraalVM 21.1.0 Java 11 CE (Java Version 11.0.11+5-jvmci-21.1-b02)

for GraalVM CE and

GraalVM 21.1.0.0 Java 11 Mandrel Distribution (Java Version 11.0.10+9)

for Mandrel.

@zakkak
Copy link
Collaborator Author

zakkak commented Apr 7, 2021

Hi @olpaw, can you please review this?

We would also like this to get backported to release/graal-vm/21.1 if possible.

Thanks

Copy link
Member

@olpaw olpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Glad we found something that works well for both of us.

@olpaw olpaw self-assigned this Apr 8, 2021
@zakkak zakkak force-pushed the native-image-bash-launcher-version branch from b45da10 to 4608618 Compare April 8, 2021 13:52
@olpaw
Copy link
Member

olpaw commented Apr 9, 2021

Your PR just merged on master (should be visible in a few minutes). I also created a PR against 21.1 and it should get included there as well.

@graalvmbot graalvmbot merged commit b948546 into oracle:master Apr 9, 2021
@zakkak zakkak deleted the native-image-bash-launcher-version branch April 9, 2021 12:18
@zakkak
Copy link
Collaborator Author

zakkak commented Apr 9, 2021

Thank you Paul!

graalvmbot pushed a commit that referenced this pull request Apr 9, 2021
…errypicked for 21.1.

PullRequest: graal/8719
@olpaw
Copy link
Member

olpaw commented Apr 12, 2021

Your PR just merged on master (should be visible in a few minutes). I also created a PR against 21.1 and it should get included there as well.

The change also got included in the release branch (on Apr 9, 2021): https://github.com/oracle/graal/commits/release/graal-vm/21.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants