Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] native-image usage docs updated for --static option #1602

Closed

Conversation

neomatrix369
Copy link
Contributor

@neomatrix369 neomatrix369 commented Aug 10, 2019

substrateVM: Added some more docs around the --static option, to make it clearer what is and isn't supported by native-image

Built a tested locally using the below commands in the substratevm folder:

${MX} build && ${MX} native-image --help 

--static option when native-image --help was invoked previously read:

    --static              build statically linked executable (requires static libc and zlib)

Currently reads:

    --static              build statically linked executable (at the moment includes static
                          libc and zlib only, hence requires them both. At the moment only
                          supports Linux).

Happy to change it to any other test to convey the same meaning of the message.

This came about post conversations in these issues:

… it clearer what is and isn't supported by native-image
@neomatrix369 neomatrix369 force-pushed the make-static-docs-clearer branch from 438c0ef to d104f62 Compare August 10, 2019 17:11
@neomatrix369 neomatrix369 changed the title native-image usage docs updated for --static option [Docs] native-image usage docs updated for --static option Aug 13, 2019
@neomatrix369
Copy link
Contributor Author

@olpaw Any progress with this PR?

@olpaw
Copy link
Member

olpaw commented Oct 16, 2019

I'd prefer to have the specifics of --static (and it's limitations) to be documented on https://www.graalvm.org/docs/reference-manual/native-image/
cc @olyagpl

@neomatrix369
Copy link
Contributor Author

I'd prefer to have the specifics of --static (and it's limitations) to be documented on https://www.graalvm.org/docs/reference-manual/native-image/
cc @olyagpl

Is this area available to change via a pull request?

@olyagpl
Copy link
Member

olyagpl commented Oct 17, 2019

@neomatrix369 , website update process is close but not similar.
I'll take care of graalvm.org. Thank you for pointing at missing information!

@olpaw olpaw closed this Dec 19, 2019
@neomatrix369 neomatrix369 deleted the make-static-docs-clearer branch April 15, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants