Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow -J-Xmx and -J-Xms to native-image command. #1591

Closed
wants to merge 1 commit into from
Closed

Allow -J-Xmx and -J-Xms to native-image command. #1591

wants to merge 1 commit into from

Conversation

bobmcwhirter
Copy link

Assume the user knows what they're doing if they ask for
specific values of Xmx/Xms when invoking native-image.

Fixes #1588

@bobmcwhirter
Copy link
Author

CI lost its mind.

Allow -J-Xmx and -J-Xms to native-image command.
3bbf76b 
Assume the user knows what they're doing if they ask for
specific values of Xmx/Xms when invoking `native-image`.

Fixes oracle#1588
@bobmcwhirter
Copy link
Author

Any interest in this?

@olpaw
Copy link
Member

olpaw commented Sep 3, 2019

@bobmcwhirter if the user wants custom xmx/xms values he should use the --no-server flag. We don't want to allow users to change mem settings for server-based builds otherwise e.g. a user using-J-Xmx100000 and another one using -J-Xmx100001 would no share the same warmed-up build server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@olpaw olpaw

Labels
native-image oca-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

native-image --no-server -J-Xmx has no effect
4 participants
@bobmcwhirter @olpaw @cstancu @graalvmbot