Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JavaInteropSpeedBench. #126

Closed
wants to merge 2 commits into from

Conversation

zapster
Copy link
Member

@zapster zapster commented Mar 14, 2016

JMH micro benchmark derived from JavaInteropSpeedTest (cf #112).

Run this from graal-core:

mx microbench -- com.oracle.truffle.api.interop.java.bench.JavaInteropSpeedBench

Note that this is the truffle alternative to graalvm/graal-core#126. I'm fine with versions.

/cc @woess

@zapster
Copy link
Member Author

zapster commented Mar 14, 2016

Wow, both alternatives (#126 and graalvm/graal-core#126) have the same PR number.

@zapster zapster force-pushed the java-interop-speed-bench branch from 75267b1 to c2cc2a2 Compare March 14, 2016 17:32
@woess
Copy link
Member

woess commented Mar 14, 2016

I'm ok with both alternatives. Leaving the decision to @jtulach.

@chumer
Copy link
Member

chumer commented Mar 14, 2016

I'd prefer having it in Truffle instead of Graal. I also want to add some DSL interpreter benchmarks.

@zapster
Copy link
Member Author

zapster commented Mar 14, 2016

@chumer Note that currently the mx microbench command is part of graal-core. We would need to move it if you want to use it in truffle without graal.

@woess
Copy link
Member

woess commented Mar 14, 2016

I guess we can remove JavaInteropSpeedTest now, too.

@zapster zapster force-pushed the java-interop-speed-bench branch from c2cc2a2 to d2647cf Compare March 15, 2016 08:27
@zapster
Copy link
Member Author

zapster commented Mar 15, 2016

Closing as graalvm/graal-core#126 has been merged.

@zapster zapster closed this Mar 15, 2016
@jtulach
Copy link
Contributor

jtulach commented Mar 15, 2016

I've merged graalvm/graal-core#126 as it is smaller change - the jmh infrastructure is already there. On the other hand, I would still like to have jmh in Truffle. We need benchmarks and having them in two repositories isn't comfortable - which is the most likely reason why we had just the one "speed" test.

dougxc added a commit that referenced this pull request Jul 11, 2016
* commit '930786b0219577b7e9ac3a22d9efae07f185397a':
  re-enable jdk8 gating
  make SeparateClassloaderTestRunner work on jdk9
  omit javadoc from gate on JDK9
  adapt to change in name of hs-comp snapshot JDK 9 binary
  workaround for Eclipse formatter behaviour being different on jdk8 and jdk9
  add jdk9 to gate
fniephaus pushed a commit to hpi-swa-lab/graal that referenced this pull request Oct 19, 2020
…at-end-of-line

Fix annotation to appear at end of line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants