added TRUFFLE_TEST distribution #107
Conversation
dougxc
force-pushed
the
add-TRUFFLE_TEST-dist
branch
from
9a3230c to
a381c80
Compare
|
/cc @rschatz |
|
lgtm |
| for prop in properties[enum]: | ||
| lines.append(newEnum + prop) | ||
|
|
||
| content = '\n'.join(lines) |
There was a problem hiding this comment.
Please use os.linesep instead of '\n'
There was a problem hiding this comment.
Really? That means the content of the jar file will be different depending on the platform where it was built. Isn't the jar file supposed to be platform independent?
(but probably it doesn't make any difference, the code that reads it should be robust for different line endings anyway...)
There was a problem hiding this comment.
Properties.store0 uses the platform dependent line separator. On the other hand, when loading a properties file, Java handles both. In any case, I will implement your request Christian.
dougxc
force-pushed
the
add-TRUFFLE_TEST-dist
branch
from
a381c80 to
d4d4ff2
Compare
| if metainfFile: | ||
| properties = self.settings.setdefault(metainfFile, {}) | ||
| for line in contents.strip().split(os.linesep): | ||
| if not line.startswith('#'): |
There was a problem hiding this comment.
I think we shouldn't rely on the file to have windows line endings on windows.
No description provided.