Test downstream users (JRuby to start with) of Truffle #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example passing log https://s3.amazonaws.com/archive.travis-ci.org/jobs/113954147/log.txt |
|
I think this makes sense to try. If we get problems getting changes in because of these tests, but not caused by a Truffle problem, we can consider disabling this again. |
chumer
added a commit
that referenced
this pull request
Mar 7, 2016
Test downstream users (JRuby to start with) of Truffle
|
You should never get problems integrating changes as the configuration means you can still push if it fails. It's just informational. |
chrisseaton
referenced
this pull request
in jruby/jruby
Mar 7, 2016
|
I would prefer if downstream projects "listen on" pull requests for Truffle and run the tests themselves and then annotated the PR with their results. It would scale better. On the other hand I understand that it is harder to implement such system from an infrastructure point of view. This is good start. |
dougxc
pushed a commit
that referenced
this pull request
Feb 4, 2017
…/truffle:JavaInteropDebug to master Debugging via Truffle interop works as tested by SLDirectDebugTest * commit '47c3bfde4cb184fccf3ca93c885477a98eac27f5': Prevent objects from one PolyglotEngine to migrate to a different one Verify the objects passed back to the engine keep their identity Don't use the JavaFunctionObject in the AOT mode Test rewritten to use DebuggingSession. Verifies that debugging works when invoked via asJavaFunction Always wrapping TruffleObject to keep reference to associated polyglot engine, unless they are known to not need it (they are coming from Java interop) Debug test invoked via JavaInterop
fniephaus
pushed a commit
to hpi-swa-lab/graal
that referenced
this pull request
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new command
mx testdownstreamand runs that on Travis as an allowed-failure (it doesn't fail the overall commit if it fails, but you still see the result). Only JRuby so far, and runs 64k of JRuby's fastest tests so it only takes a couple of minutes.This allows you to see if your changes are immediately compatible with JRuby. For example it would have caught the problems with the
iterateFrameschanges.Potential problems are if the JRuby build is broken anyway (it very rarely is, but sometimes), or if people ignore it because it's allowed-failure.
@mickjordan am I using mx correctly here?