reduce visibility of some object model implementation classes

oracle · Jan 25, 2016 · 2341199 · 2341199
1 parent 782797c
commit 2341199
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 7 deletions.
diff --git a/...e/com.oracle.truffle.object.basic/src/com/oracle/truffle/object/basic/BasicAllocator.java b/...e/com.oracle.truffle.object.basic/src/com/oracle/truffle/object/basic/BasicAllocator.java
@@ -45,7 +45,7 @@
 import static com.oracle.truffle.object.basic.BasicLocations.OBJECT_SIZE;
 import com.oracle.truffle.object.basic.BasicLocations.ObjectArrayLocation;
 
-public abstract class BasicAllocator extends ShapeImpl.BaseAllocator {
+abstract class BasicAllocator extends ShapeImpl.BaseAllocator {
 
     public BasicAllocator(LayoutImpl layout) {
         super(layout);

diff --git a/.../com.oracle.truffle.object.basic/src/com/oracle/truffle/object/basic/DefaultStrategy.java b/.../com.oracle.truffle.object.basic/src/com/oracle/truffle/object/basic/DefaultStrategy.java
@@ -85,7 +85,7 @@ public BaseAllocator createAllocator(LayoutImpl layout) {
         return new DefaultAllocatorImpl(layout);
     }
 
-    public static class DefaultAllocatorImpl extends BasicAllocator {
+    static class DefaultAllocatorImpl extends BasicAllocator {
         protected DefaultAllocatorImpl(LayoutImpl layout) {
             super(layout);
         }

diff --git a/...m.oracle.truffle.object.basic/src/com/oracle/truffle/object/basic/DynamicObjectBasic.java b/...m.oracle.truffle.object.basic/src/com/oracle/truffle/object/basic/DynamicObjectBasic.java
@@ -47,7 +47,7 @@ public class DynamicObjectBasic extends DynamicObjectImpl {
     private Object[] objext;
     private long[] primext;
 
-    public DynamicObjectBasic(Shape shape) {
+    protected DynamicObjectBasic(Shape shape) {
         super(shape);
     }
 

diff --git a/truffle/com.oracle.truffle.object.basic/src/com/oracle/truffle/object/basic/ShapeBasic.java b/truffle/com.oracle.truffle.object.basic/src/com/oracle/truffle/object/basic/ShapeBasic.java
@@ -29,11 +29,11 @@
 import com.oracle.truffle.object.Transition;
 
 public final class ShapeBasic extends ShapeImpl {
-    public ShapeBasic(Layout layout, Object sharedData, ObjectType objectType, int id) {
+    ShapeBasic(Layout layout, Object sharedData, ObjectType objectType, int id) {
         super(layout, objectType, sharedData, id);
     }
 
-    public ShapeBasic(Layout layout, Object sharedData, ShapeImpl parent, ObjectType objectType, PropertyMap propertyMap, Transition transition, Allocator allocator, int id) {
+    ShapeBasic(Layout layout, Object sharedData, ShapeImpl parent, ObjectType objectType, PropertyMap propertyMap, Transition transition, Allocator allocator, int id) {
         super(layout, parent, objectType, sharedData, propertyMap, transition, allocator, id);
     }
 

diff --git a/truffle/com.oracle.truffle.object/src/com/oracle/truffle/object/DynamicObjectImpl.java b/truffle/com.oracle.truffle.object/src/com/oracle/truffle/object/DynamicObjectImpl.java
@@ -35,7 +35,7 @@ public abstract class DynamicObjectImpl extends DynamicObject implements Cloneab
 
     public static final DebugCounter reshapeCount = DebugCounter.create("Reshape count");
 
-    public DynamicObjectImpl(Shape shape) {
+    protected DynamicObjectImpl(Shape shape) {
         assert shape instanceof ShapeImpl;
         initialize(shape);
         setShape(shape);

diff --git a/truffle/com.oracle.truffle.object/src/com/oracle/truffle/object/ObjectStorageOptions.java b/truffle/com.oracle.truffle.object/src/com/oracle/truffle/object/ObjectStorageOptions.java
@@ -24,7 +24,10 @@
 
 import static com.oracle.truffle.api.object.Layout.OPTION_PREFIX;
 
-public class ObjectStorageOptions {
+public final class ObjectStorageOptions {
+    private ObjectStorageOptions() {
+    }
+
     // Shape configuration
     /** Primitive location switch. */
     public static boolean PrimitiveLocations = booleanOption(OPTION_PREFIX + "PrimitiveLocations", true);