Support roles as a list property of Dashboards #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljpeters
commented
Aug 15, 2022
|
I am still working on saving a Dashboard with roles attached. This is not working yet because the save function in base.py is not yet converting the list of Role objects to json. |
added 3 commits
August 18, 2022 16:34
…eters/superset-api-client into support-roles-property-of-dashboards
… into support-roles-property-of-dashboards # Conflicts: # supersetapiclient/client.py
ljpeters
force-pushed
the
support-roles-property-of-dashboards
branch
from
5cd9f32 to
adae42d
Compare
|
Hi @ecederstrand or other supersetapiclient developer, I'm done with the changes I needed to store the Roles of a Dashboard. I have applied these changes to my superset setup and they work. I would like to follow through on this PR and merge it.
|
|
Hello @ljpeters , Thank you for your contribution. I was on vacations and unable to respond sooner.
Thanks again |
|
@ljpeters If you merge the latest develop into this branch, then there's now a full test suite you can add test cases to, with lots of examples on how to write tests cases. |
|
Is this still in progress? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The roles input field is revealed after enabling DASHBOARD_RBAC flag.
The information was already retrieved, but now also stored in the Dashboard during json processing.