Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update py version to 3.10 for gitactions linting #404

Merged
merged 4 commits into from
Aug 26, 2022
Merged

update py version to 3.10 for gitactions linting #404

merged 4 commits into from
Aug 26, 2022

Conversation

Mat001
Copy link
Contributor

@Mat001 Mat001 commented Aug 26, 2022

Summary

This changes are part of the ticket to cleanup and put in orer Python language versions (see ticket below).

  • remove last reference to Python 2.7 (2 lines in tests/base.py)
  • upgrade py version to 3.10 in gitactions linting

Test plan

  • passing unit tests
  • passing FSC tests
  • passing linting

Issues

@Mat001 Mat001 requested a review from a team as a code owner August 26, 2022 01:32
andrewleap-optimizely
andrewleap-optimizely approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@andrewleap-optimizely andrewleap-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mat001 Mat001 merged commit 967471b into master Aug 26, 2022
@Mat001 Mat001 deleted the mpirnovar/lang_version_cleanup branch August 26, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewleap-optimizely andrewleap-optimizely andrewleap-optimizely approved these changes

Assignees

@Mat001 Mat001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mat001 @andrewleap-optimizely