chore: remove old py versions #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For example we removed Py v3.4 already because PyYaml library in Py 3.4 can only be less than v5.4 which doesn't have a necessary security patch that versions 5.4 and greater do.
Another example is customer issue [issue link here] that required more up to date jsonschema lib version. But we could not provide that up to date version because Py 2.7 and 3.5 were capping it. See issue 370
These are all issues related to supporting older Py versions that only work with libraries up certain version number. So we get a discrepancy between which library versions old Py and new Py support. Then we decided to remove support for older py version in order to free up support for up to date libraries.
Test plan
Unit tests, FSC
Issues