Fix attribute error and task scheduling error #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dav009 @marekliszka may I get a review on this change please? I also wonder if a new PyPi release is planned. The latest I see in PyPi is 1y ago. |
Otherwise things like read_only, sub_path, etc are dropped from the final spec.
``` ================================================================ short test summary info ================================================================= FAILED test/test_task.py::test_task_can_be_scheduled_by_luigi - luigi.worker.TaskException: Task of class DummyK8sTask not initialized. Did you override __init__ and forget to call super(...).__init__? ======================================================== 1 failed, 18 passed, 1 warning in 1.69s ========================================================= nox > Command pytest failed with exit code 1 ```
|
@akislou seen your recent merge to master - can you please tell if there's a chance someone still does PR review in this repo? Thanks in advance. |
|
@psolomin 🙇 Thank you for your hard work in this contribution. I will take a look at this PR in the following days 🙇 |
|
@psolomin We will take a look at your PR hopefully this week. Thanks for your work! |
Co-authored-by: blackwolf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #24 and missing attribute error in the logging call:
pod.namespace.It also makes it possible to specify full attributes' sets for volume mounts.