Add support for group process monitoring #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mithunbelur
reviewed
Dec 12, 2024
deploy.yaml
Outdated
| @@ -101,6 +101,12 @@ spec: | |||
| labels: | |||
| app: otelcontribcol | |||
| spec: | |||
| volumes: | |||
There was a problem hiding this comment.
I hope this volume is not required. Remove it.
mithunbelur
reviewed
Dec 12, 2024
| | [processes] | Linux, Mac | Process count metrics | | ||
| | [process] | Linux, Windows, Mac | Per process CPU, Memory, and Disk I/O metrics | | ||
| | [system] | Linux, Windows, Mac | Miscellaneous system metrics | | ||
| | [groupprocess] | Linux, Windows, Mac | Per process group CPU, Memory, and Disk I/O metrics | |
There was a problem hiding this comment.
Add a keywork aggregated metrics of all processes of group
mithunbelur
reviewed
Dec 12, 2024
| In this example, the groupprocessscraper is configured to scrape metrics for processes that match the specified comm, exe, and cmdline criteria. The group_name is used to identify the group of processes being monitored. | ||
| For `comm` and `exe`, the list of strings is an `OR`, meaning any process matching any of the strings will be added to the process group. | ||
| For `cmdline`, the list of regexes is an `AND`, meaning they all must match. | ||
|
|
There was a problem hiding this comment.
Also, add a line.
If more than one out of(comm, exe and cmdline) is given all of them has to match.
if a process matches to one group, the same process will not be part of other groups.
mithunbelur
reviewed
Dec 13, 2024
| config *Config | ||
| mb *metadata.MetricsBuilder | ||
| scrapeProcessDelay time.Duration | ||
| ucals map[int32]*ucal.CPUUtilizationCalculator |
mithunbelur
reviewed
Dec 13, 2024
| // Copyright The OpenTelemetry Authors | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package ucal // import "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/hostmetricsreceiver/internal/scraper/groupprocessscraper/ucal" |
There was a problem hiding this comment.
Remove this if its not used.
There was a problem hiding this comment.
okay, will test once after removing
There was a problem hiding this comment.
I have tested after removing ucal package and everything seems to be working fine. Hence removing this package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding support for group process monitoring
Link to tracking Issue:
Testing:
Documentation: