Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Allow Card Titles to have two lines #1822

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

LorisSigrist
Copy link
Collaborator

This PR changes the line-clamp on the card titles from one to two.

Having just one line is insufficient for a properly descriptive title. Important information either had to be omitted (bad for SEO), or we had to accept that it would cut off (bad UX).

With the two-line titles we now have a litte more space.

Screenshot 2023-12-05 at 09 23 08

Using text-wrap: balance makes the wrapping a little nicer.

Screen.Recording.2023-12-05.at.09.23.28.mov

Copy link

changeset-bot bot commented Dec 5, 2023

⚠️ No Changeset found

Latest commit: 011fe5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samuelstroschein samuelstroschein temporarily deployed to disable-line-clamp-on-marketplace-titles - badge-service PR #1822 December 5, 2023 08:27 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to disable-line-clamp-on-marketplace-titles - git-proxy PR #1822 December 5, 2023 08:27 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to disable-line-clamp-on-marketplace-titles - inlang-website PR #1822 December 5, 2023 08:39 — with Render Destroyed
@flornkm flornkm merged commit a64e801 into main Dec 5, 2023
@flornkm flornkm deleted the disable-line-clamp-on-marketplace-titles branch December 5, 2023 08:57
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants