Merge stores after every expression statement #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingweitian
reviewed
Sep 10, 2020
| String name = uniqueName("mergeStoreBeforeIf"); | ||
| Element owner = findOwner(); | ||
| ExpressionTree initializer = tree.getExpression(); | ||
| VariableTree auxillaryVariable = |
There was a problem hiding this comment.
Is this auxillary a typo? Should it be auxiliary?
|
Closed in favor of #161 |
zcai1
added a commit
to zcai1/checker-framework
that referenced
this pull request
Feb 8, 2022
Co-authored-by: d367wang <[email protected]> Co-authored-by: d367wang <[email protected]> Co-authored-by: Werner Dietl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative solution to PR#154. Instead of merging stores only after expression statements followed by
if, it merges stores after expression statement by making it the initializer to an auxiliary variable.